gosmopolitan

package module
v1.2.2 Latest Latest
Warning

This package is not in the latest version of its module.

Go to latest
Published: Sep 6, 2023 License: GPL-3.0 Imports: 11 Imported by: 4

README

gosmopolitan

GitHub Workflow Status (main branch) Codecov GitHub license info GitHub go.mod Go version Go Report Card Go Reference

简体中文

gosmopolitan checks your Go codebase for code smells that may prove to be hindrance to internationalization ("i18n") and/or localization ("l10n").

The name is a wordplay on "cosmopolitan".

Checks

Currently gosmopolitan checks for the following anti-patterns:

  • Occurrences of string literals containing characters from certain writing systems.

    Existence of such strings often means the relevant logic is hard to internationalize, or at least, require special care when doing i18n/l10n.

  • Usages of time.Local.

    An internationalized app or library should almost never process time and date values in the timezone in which it is running; instead one should use the respective user preference, or the timezone as dictated by the domain logic.

Note that local times are produced in a lot more ways than via direct casts to time.Local alone, such as:

  • time.LoadLocation("Local")
  • received from a time.Ticker
  • functions explicitly documented to return local times
    • time.Now()
    • time.Unix()
    • time.UnixMilli()
    • time.UnixMicro()

Proper identification of these use cases require a fairly complete dataflow analysis pass, which is not implemented currently. In addition, right now you have to pay close attention to externally-provided time values (such as from your framework like Gin or gRPC) as they are not properly tracked either.

Caveats

Note that the checks implemented here are only suitable for codebases with the following characteristics, and may not suit your particular project's needs:

  • Originally developed for an audience using non-Latin writing system(s),
  • Returns bare strings intended for humans containing such non-Latin characters, and
  • May occasionally (or frequently) refer to the system timezone, but is architecturally forbidden/discouraged to just treat the system timezone as the reference timezone.

For example, the lints may prove valuable if you're revamping a web service originally targetting the Chinese market (hence producing strings with Chinese characters all over the place) to be more i18n-aware. Conversely, if you want to identify some of the i18n-naïve places in an English-only app, the linter will output nothing.

golangci-lint integration

gosmopolitan support has been merged into golangci-lint, and will be usable out-of-the-box in golangci-lint v1.53.0 or later.

Due to the opinionated coding style this linter advocates and checks for, if you have enable-all: true in your golangci.yml and your project deals a lot with Chinese text and/or time.Local, then you'll get flooded with lints when you upgrade to golangci-lint v1.53.0. Just disable this linter (and better yet, move away from enable-all: true) if the style does not suit your specific use case.

License

gosmopolitan is licensed under the GPL license, version 3 or later.

Documentation

Index

Constants

This section is empty.

Variables

View Source
var DefaultAnalyzer = NewAnalyzer()

Functions

func NewAnalyzer

func NewAnalyzer() *analysis.Analyzer

func NewAnalyzerWithConfig

func NewAnalyzerWithConfig(cfg *AnalyzerConfig) *analysis.Analyzer

Types

type AnalyzerConfig

type AnalyzerConfig struct {
	// LookAtTests is flag controlling whether the lints are going to look at
	// test files, despite other config knobs of the Go analysis tooling
	// framework telling us otherwise.
	//
	// By default gosmopolitan does not look at test files, because i18n-aware
	// apps most probably have many unmarked strings in test cases, and names
	// and descriptions *of* test cases are probably in the program's original
	// natural language too.
	LookAtTests bool
	// EscapeHatches is optionally a list of fully qualified names, in the
	// `(full/pkg/path).name` form, to act as "i18n escape hatches". Inside
	// call-like expressions to those names, the string literal script check
	// is ignored.
	//
	// With this functionality in place, you can use type aliases like
	// `type R = string` as markers, or have explicitly i18n-aware functions
	// exempt from the checks.
	EscapeHatches []string
	// WatchForScripts is optionally a list of Unicode script names to watch
	// for any usage in string literals. The range of supported scripts is
	// determined by the [unicode.Scripts] map and values are case-sensitive.
	WatchForScripts []string
	// AllowTimeLocal is flag controlling whether usages of [time.Local] are
	// allowed (i.e. not reported).
	AllowTimeLocal bool
}

Directories

Path Synopsis
cmd

Jump to

Keyboard shortcuts

? : This menu
/ : Search site
f or F : Jump to
y or Y : Canonical URL